qdisc: expose fq throttled events as node_qdisc_throttled_total - #3792
Open
2matzzz wants to merge 1 commit into
Open
qdisc: expose fq throttled events as node_qdisc_throttled_total#37922matzzz wants to merge 1 commit into
2matzzz wants to merge 1 commit into
Conversation
The ema/qdisc library has parsed the fq qdisc's extended statistics (including the throttled counter) since 2017, one day after this collector was merged, but the field was never wired into a metric. Expose it as node_qdisc_throttled_total so that users running fq with maxrate pacing can observe how often the qdisc throttles transmission, e.g. to verify whether egress pacing is actually engaging. For qdiscs other than fq the value is reported as 0, consistent with how the other uniform per-qdisc metrics behave. Assisted-by: Claude Code Signed-off-by: Yusuke Matsumoto <2matzzz@gmail.com>
2matzzz
force-pushed
the
qdisc-throttled
branch
from
August 20, 2026 10:55
cdc26f0 to
5593cbd
Compare
2matzzz
marked this pull request as draft
August 20, 2026 10:57
2matzzz
marked this pull request as ready for review
August 20, 2026 13:02
Member
|
/workflow-approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
node_qdisc_throttled_total(counter,device/kindlabels) to the qdisc collector, sourced fromQdiscInfo.Throttled.The ema/qdisc library has parsed the fq qdisc's extended stats (
Throttled, among others) since ema/qdisc@e2e5ae4 (2017-05-24) — merged one day after #580 introduced this collector — but the field was never wired into a metric. This follows the same pattern as #1732, which wired the library's backlog/qlen fields through.Use case: with
fqused for egress pacing (maxrate), this counter shows whether and how often pacing actually engages — packets are delayed rather than dropped, so none of the existing drop/overlimit metrics capture it. For non-fq qdiscs the value is 0, consistent with the collector's uniform metric emission.Testing: fixtures updated (
results.json,e2e-output.txt,e2e-64k-page-output.txt); verified by running the exporter with--collector.qdisc.fixturesand confirming the new series alongside unchanged existing ones.cc @SuperQ